Review Request: Change check for presence plasmoid to only check if the service name is registered

Dominik Cermak d.cermak at arcor.de
Mon Oct 29 19:43:47 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107045/#review21113
-----------------------------------------------------------

Ship it!


Ship It!

- Dominik Cermak


On Oct. 26, 2012, 4:54 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107045/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2012, 4:54 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Change check for presence plasmoid to only check if the dbus service name is registered.
> 
> I wrote it for an idea (that didn't work) to deal with multiple instances of the presence applet.
> The code in the presence applet is still smaller, faster and simpler with this patch, so I think it's worth putting in anyway.
> 
> 
> Diffs
> -----
> 
>   main-widget.cpp ff0056a756e25af23b72f922387ebcbea061405e 
> 
> Diff: http://git.reviewboard.kde.org/r/107045/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121029/9dbacb12/attachment.html>


More information about the KDE-Telepathy mailing list