Review Request: Print debug messages only in debug mode

Dan Vrátil dvratil at redhat.com
Thu Oct 25 14:26:45 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106280/#review20883
-----------------------------------------------------------


What difference does this make? debugfn() just calls qDebug(), which only works when the library is built in Debug mode.

- Dan Vrátil


On Aug. 30, 2012, 4:22 p.m., Gustavo P. Boiko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106280/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2012, 4:22 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Print debug messages only if telepathy-logger-qt build type is Debug
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 25e8375a90638d7fba2785dce3767744eb324390 
>   TelepathyLoggerQt4/pending-logger.cpp 6d2a58b16f7fd1f4482e6b7ffd54d1af87042f6c 
>   TelepathyLoggerQt4/utils.cpp 2a312777fa3453922e41a54e66afac5a923f3742 
> 
> Diff: http://git.reviewboard.kde.org/r/106280/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gustavo P. Boiko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121025/77bdf12f/attachment.html>


More information about the KDE-Telepathy mailing list