Review Request: Don't show EditAccountDialog until KWallet is opened

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Thu Oct 25 11:06:40 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107033/#review20860
-----------------------------------------------------------

Ship it!


Works great with https://git.reviewboard.kde.org/r/107034/

Thanks!

- Daniele Elmo Domenichelli


On Oct. 25, 2012, 9:24 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107033/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2012, 9:24 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Wait until KWallet is opened, then allow dialog to be shown. Otherwise you see just an empty dialog with "OK" and "Cancel" buttons.
> 
> 
> This addresses bug 308079.
>     http://bugs.kde.org/show_bug.cgi?id=308079
> 
> 
> Diffs
> -----
> 
>   src/edit-account-dialog.h 08a3481 
>   src/edit-account-dialog.cpp a747242 
> 
> Diff: http://git.reviewboard.kde.org/r/107033/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121025/b8f93689/attachment.html>


More information about the KDE-Telepathy mailing list