Review Request: Reopen wallet if it was force-closed

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Thu Oct 25 11:05:41 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107034/#review20859
-----------------------------------------------------------

Ship it!


Ship It!

- Daniele Elmo Domenichelli


On Oct. 25, 2012, 10:51 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107034/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2012, 10:51 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> See the bug for description of the problem.
> 
> When calling KTp::WalletInterface::openWallet(), this patch simply checks, whether the wallet was opened before, but now is closed and in such case it reopens it. If the wallet was not opened before (because it's disabled or user decided not to open it), then it does nothing.
> 
> 
> This addresses bug 308973.
>     http://bugs.kde.org/show_bug.cgi?id=308973
> 
> 
> Diffs
> -----
> 
>   KTp/wallet-interface.cpp c60899a 
> 
> Diff: http://git.reviewboard.kde.org/r/107034/diff/
> 
> 
> Testing
> -------
> 
> Tried to reproduce steps in the bug report - got presented with KWallet password prompt when clicked "Edit Account" after force-closing the Wallet.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121025/aeb8d614/attachment.html>


More information about the KDE-Telepathy mailing list