Review Request: Use palette from QStyleOptionViewItem instead of having our own class palette variable

Rohan Garg rohangarg at kubuntu.org
Tue Oct 23 11:16:35 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107008/#review20733
-----------------------------------------------------------

Ship it!


Ship It!

- Rohan Garg


On Oct. 23, 2012, 11:03 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107008/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2012, 11:03 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This removes the palette that's being set in constructor and uses the option's palette directly.
> 
> 
> This addresses bug 308820.
>     http://bugs.kde.org/show_bug.cgi?id=308820
> 
> 
> Diffs
> -----
> 
>   abstract-contact-delegate.h 920fd48 
>   abstract-contact-delegate.cpp f5f2a05 
>   contact-delegate-compact.cpp 1915397 
>   contact-delegate.cpp f79b1d5 
> 
> Diff: http://git.reviewboard.kde.org/r/107008/diff/
> 
> 
> Testing
> -------
> 
> Switched color schemes, works nice.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121023/fd0aec55/attachment.html>


More information about the KDE-Telepathy mailing list