Review Request: get rid of hardcoded sizes
David Edmundson
kde at davidedmundson.co.uk
Mon Oct 22 18:12:03 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106855/#review20687
-----------------------------------------------------------
Ship it!
Ship It!
- David Edmundson
On Oct. 21, 2012, 3:07 p.m., Michael Zanetti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106855/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2012, 3:07 p.m.)
>
>
> Review request for Telepathy and David Edmundson.
>
>
> Description
> -------
>
> Right now the ktp-contact-list has some hard coded values for sizes which makes it very hard to use on high-res screens.
>
> This patch uses KIconLoader to paint the icons using the sizes configured in the systemsettings instead of the hardcoded values.
>
>
> Diffs
> -----
>
> contact-delegate-compact.cpp 1915397
> contact-delegate.h 8508f7e
> contact-delegate.cpp f79b1d5
> contact-overlays.cpp 8ea1b1a
>
> Diff: http://git.reviewboard.kde.org/r/106855/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Zanetti
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121022/ae704151/attachment.html>
More information about the KDE-Telepathy
mailing list