Review Request: Replace ListView with QTextEdit in ktp-debugger

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106809/#review20436
-----------------------------------------------------------

Ship it!


I didn't exactly have this in mind when I originally wrote the code, but what the heck, it's far better than the current code. Ship it.

- George Kiagiadakis


On Oct. 11, 2012, 11:10 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106809/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 11:10 p.m.)
> 
> 
> Review request for Telepathy and George Kiagiadakis.
> 
> 
> Description
> -------
> 
> Replace ListView with QTextEdit in ktp-debugger
> 
> This makes it magnitudes times faster. Also allows for selecting text and copy+paste into bug reports/attachments
> 
> (diff is slightly confusing, message-view code is mostly the same as in messages-model.)
> 
> I'd also like to backport this into the 0.5 series. Right now the debugger is practically useless. To the point that I ask people for bugs the old classic way. Would be good to use this from now on.
> 
> 
> Diffs
> -----
> 
>   tools/debugger/CMakeLists.txt 159b124de916c9020073930c0528d8ae790ffeac 
>   tools/debugger/debug-message-view.h PRE-CREATION 
>   tools/debugger/debug-message-view.cpp PRE-CREATION 
>   tools/debugger/debug-messages-model.h b4da9b7571960e20c736b3306465c565ef38a5ee 
>   tools/debugger/debug-messages-model.cpp f174c78cb94b45da704f214125f6e9f978b40026 
>   tools/debugger/main-window.cpp 39a40ee905b8d5251a3e42b46ef5bf46941d9e75 
>   tools/debugger/main-window.ui 1e3bfff919affe1b9662cdc2f31490a3bc33dbc4 
> 
> Diff: http://git.reviewboard.kde.org/r/106809/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121015/b564822e/attachment.html>