Review Request: Fix chat scrolling on the plasmoid for real (tm)

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106791/#review20190
-----------------------------------------------------------

Ship it!


General rule is no hacks, unless you've tried everything else.
You have, and you've opened and linked to an upstream bug report.

As far as I'm concerned. You've done everything right. and it's a ship it from me.

- David Edmundson


On Oct. 11, 2012, 11:52 a.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106791/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 11:52 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> There was something that wasn't working well still with the scrolling. We didn't have the problems we used to have but it still scrolled to almost the end but not yet. Ugly.
> 
> I started to investigate again and figured out that it was about a bug in Qt [1] (yay, :D). Then after playing with the test case I found out that I could workaround it by calling positionViewAtEnd() twice.
> 
> It's ugly and I'll understand that nobody will want to have this in our codebase. But I guess the alternative is fixing Qt or stop using sections which have their con's as well...
> 
> [1] https://bugreports.qt-project.org/browse/QTBUG-27529?focusedCommentId=185551#comment-185551
> 
> 
> This addresses bug 298392.
>     http://bugs.kde.org/show_bug.cgi?id=298392
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml b3e3631 
> 
> Diff: http://git.reviewboard.kde.org/r/106791/diff/
> 
> 
> Testing
> -------
> 
> Tested it in my test cases I have, then made sure it worked well by chatting to myself.
> 
> I guess I thought it worked before because when I fixed the ScrollBar, I did it for a shared problem I had with Muon Discover as well and assumed a little that it would work here as well... :/ (in muon I don't have the sections problem)
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121011/95758b7d/attachment.html>