Review Request: Move channel filters out of main and with the relevant handler

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Fri Oct 5 08:41:40 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106736/#review19951
-----------------------------------------------------------

Ship it!


Just make the 2 methods in the cpp files static...


sasl-handler.cpp
<http://git.reviewboard.kde.org/r/106736/#comment15812>

    static inline



tls-handler.cpp
<http://git.reviewboard.kde.org/r/106736/#comment15813>

    static inline


- Daniele Elmo Domenichelli


On Oct. 5, 2012, 12:23 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106736/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2012, 12:23 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Code cleanup.
> 
> Move channel filters out of main and alongside their relevant handler
> 
> 
> Diffs
> -----
> 
>   main.cpp d77d800a06e479efecc6c561d75e4ddea58a1bda 
>   sasl-handler.h dcb34e4d8df86fc79914a1bd34bb17e551a39d63 
>   sasl-handler.cpp d4537258ce6c192401736f260d7fa97b3158ec0a 
>   tls-handler.h 0e036b1ee90d70ba2c46cab28ebf6c7f8e10d148 
>   tls-handler.cpp 038d26d4b4a6cd6fd8083a79c884719db7d72db9 
> 
> Diff: http://git.reviewboard.kde.org/r/106736/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121005/a4454272/attachment.html>


More information about the KDE-Telepathy mailing list