Review Request: Don't use an entire model to loop through contacts

[David Edmundson]

> On Oct. 2, 2012, 10:07 p.m., Dan Vratil wrote:
> > Nice trick with the loop! 
> > 
> > Just use Q_FOREACH instead of foreach and ship it!
> 
> Aleix Pol Gonzalez wrote:
>     FWIW I don't see the point of considering this an error. If it compiles, it works, if it doesn't then the dependencies are deeply messed up.
> 
> Dan Vratil wrote:
>     If you have Qt compiled with -DQT_NO_KEYWORDS then foreach is not defined, only Q_FOREACH.
> 
> Aleix Pol Gonzalez wrote:
>     You can compile it with QT_NO_CLIPBOARD as well, and not for this reason we're ifdef'ing everything that uses the clipboard. (same with QT_NO_STL, QT_NO_THREAD, QT_NO_INPUTDIALOG, QT_NO_CURSOR, QT_NO_QWS_MOUSE, QT_NO_TEXTEDIT, QT_NO_SYNTAXHIGHLIGHTER and a big etc.)

IIRC ktp-call-ui /needs/ to be compiled like that, as otherwise it can clash with keywords in gstreamer, at which point it became a standard "KTp coding style" thing.

However, if that is the case then the contact-runner should have this flag set.

Anyway, I suggest taking this to the ML if you want to discuss it. (George K or DrDanz will be able to answer better). 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106700/#review19799
-----------------------------------------------------------


On Oct. 2, 2012, 9:45 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106700/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 9:45 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Don't use an entire model to loop through contacts.
> 
> Should be faster, and simpler.
> 
> 
> Diffs
> -----
> 
>   src/contactrunner.h 55e7e9de017dca23fa1d6551d4ce99997d05cad3 
>   src/contactrunner.cpp 48e01bf10b902932631b6e987c191d4d868e7d82 
> 
> Diff: http://git.reviewboard.kde.org/r/106700/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121002/a19d873c/attachment.html>