Review Request: Don't use an entire model to loop through contacts

[Aleix Pol Gonzalez]

> On Oct. 2, 2012, 10:07 p.m., Dan Vratil wrote:
> > Nice trick with the loop! 
> > 
> > Just use Q_FOREACH instead of foreach and ship it!

FWIW I don't see the point of considering this an error. If it compiles, it works, if it doesn't then the dependencies are deeply messed up.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106700/#review19799
-----------------------------------------------------------


On Oct. 2, 2012, 9:45 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106700/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 9:45 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Don't use an entire model to loop through contacts.
> 
> Should be faster, and simpler.
> 
> 
> Diffs
> -----
> 
>   src/contactrunner.h 55e7e9de017dca23fa1d6551d4ce99997d05cad3 
>   src/contactrunner.cpp 48e01bf10b902932631b6e987c191d4d868e7d82 
> 
> Diff: http://git.reviewboard.kde.org/r/106700/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121002/bdbe5f7d/attachment.html>