Review Request: Remove somewhat pointless AccountItem class.

David Edmundson kde at davidedmundson.co.uk
Tue Oct 2 18:41:17 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106694/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Remove somewhat pointless AccountItem class.

This should result in a simpler, faster AccountsModel.

The old code had some icon overlaying, which would never do anything (a misunderstanding of isValid()), and making lots of new QObjects.


Diffs
-----

  src/CMakeLists.txt ee82fd0f82b3c158f1bef670b08120ef22974b6c 
  src/account-item.h a2fee834c7e0e65931fa82c437be754e95ec333c 
  src/account-item.cpp 8efc78fb135b7cf29b750fcfeb11c1b94eaa44a6 
  src/accounts-list-model.h 10786674ab0d5a7bada9f6b3e3be9acd0aa235cd 
  src/accounts-list-model.cpp 4a015fa517c625099f4fb05da3572e53b243d2ad 

Diff: http://git.reviewboard.kde.org/r/106694/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121002/eb526c8c/attachment.html>


More information about the KDE-Telepathy mailing list