Review Request: Add 'Open log viewer' action to context menu

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106688/#review19748
-----------------------------------------------------------

Ship it!


ship it from me, would like mck182 to look too.


context-menu.cpp
<http://git.reviewboard.kde.org/r/106688/#comment15722>

    I don't like this at all :S 
    but I think it is the only way to do it at the moment.
    
    I had a draft branch that exposed AccountrPtr from the contactItem. Remind me to re-push for this.


- David Edmundson


On Oct. 2, 2012, 12:56 p.m., Dan Vratil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106688/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2012, 12:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This adds "Open log viewer" action to contact context menu in contact list. The action is disabled when there are no logs to display - because of that contact list needs to be linked against TelepathyLoggerQt4, so I added it as a hard dependency.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7cb36cf 
>   context-menu.h 5a30c6d 
>   context-menu.cpp 10f3d90 
> 
> Diff: http://git.reviewboard.kde.org/r/106688/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vratil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121002/52dc4e5b/attachment.html>