Review Request: Filter account by global filter string, instead of only display string

David Edmundson david at davidedmundson.co.uk
Wed Nov 28 21:40:34 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107501/#review22729
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Nov. 28, 2012, 2:13 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107501/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2012, 2:13 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> This partly depends on #107500, due to a bug in globalFilterString which makes globalFilterString not work, but the idea is, some user might want to filter account by non-display string.
> 
> One use case: most of my account display name is in Chinese, while type Chinese will take much more effort that typing English, I also want to search contact by email address. Thus use globalFilter here make more sense.
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.cpp 564f368 
> 
> Diff: http://git.reviewboard.kde.org/r/107501/diff/
> 
> 
> Testing
> -------
> 
> Test with #107500, work as excepted.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121128/03675460/attachment.html>


More information about the KDE-Telepathy mailing list