Review Request: Make AccountsFilterModel can be also filtered by Id, and fix globalFilterString
Commit Hook
null at kde.org
Wed Nov 28 16:58:05 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107500/#review22705
-----------------------------------------------------------
This review has been submitted with commit 86584d5d16ea6a781307f7ab9fa6bb543e9a0554 by Weng Xuetian to branch master.
- Commit Hook
On Nov. 28, 2012, 3:38 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107500/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2012, 3:38 p.m.)
>
>
> Review request for Telepathy and Daniele Elmo Domenichelli.
>
>
> Description
> -------
>
> This patch add Id into filterable string, id also contains some useful string, for gabble it's something like email address.
>
> And when globalFilterString is not empty, filterFunction always return true, add return false at last if globalFilterString is not empty.
>
>
> Diffs
> -----
>
> KTp/Models/accounts-filter-model.h b0d7402
> KTp/Models/accounts-filter-model.cpp eeecc77
>
> Diff: http://git.reviewboard.kde.org/r/107500/diff/
>
>
> Testing
> -------
>
> Compiles, No problem.
>
>
> Thanks,
>
> Xuetian Weng
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121128/a63ba12f/attachment.html>
More information about the KDE-Telepathy
mailing list