Review Request: Implement channel password handling

Rohan Garg rohangarg at kubuntu.org
Wed Nov 28 06:44:49 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107089/
-----------------------------------------------------------

(Updated Nov. 28, 2012, 6:44 a.m.)


Review request for Telepathy.


Changes
-------

Fixup as per review comments


Description
-------

Implement password handling for channels that have a password interface


This addresses bug 288502.
    http://bugs.kde.org/show_bug.cgi?id=288502


Diffs (updated)
-----

  CMakeLists.txt 09ffb1b06723ce65f3d9893ecfb850e5d8191796 
  KTp.ConfAuthObserver.client PRE-CREATION 
  conference-auth-observer.h PRE-CREATION 
  conference-auth-observer.cpp PRE-CREATION 
  conference-auth-op.h PRE-CREATION 
  conference-auth-op.cpp PRE-CREATION 
  main.cpp d77d800a06e479efecc6c561d75e4ddea58a1bda 
  org.freedesktop.Telepathy.Client.KTp.ConfAuthObserver.service.in PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/107089/diff/


Testing
-------

Opens password dialog when joining a password protected room. Can't make a password protected room, yet, so it's advised to use this in conjuction with pidgin to test.


Thanks,

Rohan Garg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121128/ff4c0ea4/attachment.html>


More information about the KDE-Telepathy mailing list