Review Request: Check clientTypes when ordering by presence

David Edmundson david at davidedmundson.co.uk
Mon Nov 26 18:23:33 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107479/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Check clientTypes when ordering by presence
This patch makes the sorting consider online + on phone as being less 'available' as someone who is just 'online', but still more available than someone who is away.

I think it's a good idea from my usage but it's not been discussed properly, so comment if you disagree with the idea as well as the code.

(Also simplified some code just above my patch)


Diffs
-----

  KTp/Models/accounts-filter-model.cpp eeecc77a4e0d776e31b398b91df3504f909b6a41 

Diff: http://git.reviewboard.kde.org/r/107479/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121126/150b8df9/attachment.html>


More information about the KDE-Telepathy mailing list