Review Request: Fix a bug in which model items could be rendered with a white font on white.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107430/#review22416
-----------------------------------------------------------

Ship it!


Nice catch!

- Martin Klapetek


On Nov. 23, 2012, 3:14 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107430/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2012, 3:14 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix a bug in which model items could be rendered with a white font on white.
> 
> https://bugs.kde.org/show_bug.cgi?id=310081
> 
> 
> Diffs
> -----
> 
>   abstract-contact-delegate.cpp 6340e3a1273a24a680af01bfb2cd364e2e932f77 
>   contact-delegate-compact.cpp 154478de8d2654c948f86566e5eb2a26040c1cc7 
>   contact-delegate.cpp 27a8e5f28b6567bf78142ea3f988f7b2dbfa5089 
> 
> Diff: http://git.reviewboard.kde.org/r/107430/diff/
> 
> 
> Testing
> -------
> 
> I managed (by accident) to get a 100% reproducible case whilst testing my GroupsModel.
> 
> I then checked what status flags Oxygen-Style uses to decide which background to paint. State_Selected is a more obvious flag, somehow on bootup we were able to focus an item without selecting it, and that caused the issue.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121123/0e8918b9/attachment.html>