Review Request: Add 'Open Log Viewer' action to contact list overlay

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107404/#review22310
-----------------------------------------------------------



contact-overlays.cpp
<http://git.reviewboard.kde.org/r/107404/#comment17145>

    You're passing in 0 as the role to check whether logs are enabled or not?
    
    So it will be enabled if Qt::DisplayRole is set... 
    
    That doesn't seem right?
    


- David Edmundson


On Nov. 21, 2012, 1:34 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107404/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2012, 1:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Everything else is there, why not logviewer? :)
> 
> 
> This addresses bug 304135.
>     http://bugs.kde.org/show_bug.cgi?id=304135
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.cpp 5a0f96d 
>   contact-overlays.h c93d462 
>   contact-overlays.cpp bc2671b 
> 
> Diff: http://git.reviewboard.kde.org/r/107404/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121121/3437e954/attachment-0001.html>