Review Request: Move away from ContactModelItem* and to KTp::Actions in ContactListApplet

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107396/#review22300
-----------------------------------------------------------

Ship it!


Ship It!

- Dan Vrátil


On Nov. 21, 2012, 5:45 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107396/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2012, 5:45 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Move away from ContactModelItem* and to KTp::Actions in ContactListApplet. Also show debug output on channel request failure.
> 
> Pleasantly surprised that QML handles passing Tp::SharedPtr<> about perfectly \o/
> 
> 
> Diffs
> -----
> 
>   declarative-plugin/contact-list.h dee39eef2869b0755acc78699a2ef09db4ed8f7d 
>   declarative-plugin/contact-list.cpp 92a6022d3626e27a2ac43f97f41b69cf4ec84960 
>   org.kde.ktp.contactlist/contents/ui/ListContactDelegate.qml 0f78f87268dde6f69324301238b9b46ed70411c3 
> 
> Diff: http://git.reviewboard.kde.org/r/107396/diff/
> 
> 
> Testing
> -------
> 
> Started a chat :)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121121/6cfa0d0f/attachment.html>