Review Request: Remove AccountContact class

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107400/#review22298
-----------------------------------------------------------

Ship it!


- Dan Vrátil


On Nov. 21, 2012, 9:22 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107400/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2012, 9:22 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Remove AccountContact class
> 
> In practice this didn't really work. It becomes difficult to track the changes of a contact without rendering this uesless.
> Instead expose AccountForContact as public API.
> 
> I was making the ContactListModel and found this wasn't really working. Current only other user in kded-module which only uses the ContactPtr anyway.
> 
> I have a patch for the ContactNotifier ready.
> 
> 
> Diffs
> -----
> 
>   KTp/global-contact-manager.h 4cfa58c229e427427fee0bbe27978d13870f0e99 
>   KTp/global-contact-manager.cpp 57de505c60668d61c89b4c79fa9d3f25a8aff726 
> 
> Diff: http://git.reviewboard.kde.org/r/107400/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121121/c080d535/attachment.html>