Review Request: Let plugins generate a "default" display name

David Edmundson david at davidedmundson.co.uk
Wed Nov 21 03:16:36 UTC 2012 


> On Feb. 27, 2012, 12:46 a.m., David Edmundson wrote:
> > Happy with the code, but all the signals about "displayNameChanged" are now rendered useless, as we only care about the display name when the user accepts the dialog so no-one listens for them.
> > Personally I think they should be removed, but I won't argue if they're left.
> > 
> > Discussed on IRC. Waiting on DrDanz to have a think about it and decide whether to remove them or no.
> 
> David Edmundson wrote:
>     This is an important official review comment.
>     Merge this already!

DrDanz's comment on this:

> (This review) was good, but I wanted to simplify it to make it static, but I
> always forget when I have some time! :P Perhaps, if it still work, We can
> leave it dynamic, and just don't use it.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103628/#review10937
-----------------------------------------------------------


On Feb. 23, 2012, 7:21 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103628/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2012, 7:21 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This patch lets each plugin generate a "default" display name, based on the parameters set.
> - Default name is used if display name is empty or if it is the previous default name.
> - If the current display name _contains_ the old default display name, only the default part is replaced. For example, if old default name is foo at bar.com and the display name is Foo <foo at bar.com> when the user changes something and the new default display name is foo at buz.com, the new display name becomes Foo <foo at buz.com> (This happens realtime while the user is typing)
> - Otherwise the user set display name is just left unchanged.
> 
> Also all the plugins were updated. For accounts without a specific plugin, the display name is set automatically using the "account" parameter if it exists. If it does not exist the user will have to add it manually, but this doesn't seem a big issue to me...
> 
> Branch here: http://quickgit.kde.org/?p=clones%2Ftelepathy-accounts-kcm%2Fddomenichelli%2Ftelepathy-accounts-kcm.git&a=shortlog&h=refs/heads/displayname
> 
> 
> This addresses bug 284930.
>     http://bugs.kde.org/show_bug.cgi?id=284930
> 
> 
> Diffs
> -----
> 
>   plugins/butterfly/main-options-widget.h 19a44c818544aa747718505b4e3db158cda79f4b 
>   plugins/butterfly/main-options-widget.cpp 7e4800717673b6ee7d549bae7afbf3126e0a28d4 
>   plugins/gabble/main-options-widget-facebook.h abeacc5c5b9a387d1e68151ea835bff306e5bc96 
>   plugins/gabble/main-options-widget-facebook.cpp 7e800bef0c6a1bf99bbfea84d3cb411c0ebac280 
>   plugins/gabble/main-options-widget-googletalk.h b73df1129648dedb084af2d1f8ee056d06fa6bd4 
>   plugins/gabble/main-options-widget-googletalk.cpp ed97bffb0dab256af5ab2a17ad1279094e49092b 
>   plugins/gabble/main-options-widget-kde-talk.h 58673ccbd51791195e125b4e1da5ab5c0f28bd5a 
>   plugins/gabble/main-options-widget-kde-talk.cpp ad1399fb5e5dc9e08a823a85009a78e5f0958393 
>   plugins/gabble/main-options-widget-msn.h 6d70cbeb171c7c10161e54a932bc1c499ea8d345 
>   plugins/gabble/main-options-widget-msn.cpp 913a808810b2368850657bc4f76edfa4d7d1f681 
>   plugins/gabble/main-options-widget.h 46c071862a7a17b784cb17e453f023802f2c0da5 
>   plugins/gabble/main-options-widget.cpp 927bb32f1e29a7e4e7dbed64ed4eb7df56e96014 
>   plugins/haze/aim-main-options-widget.h b966fb6ea06378a3e01e82ab4bd56f645036e116 
>   plugins/haze/aim-main-options-widget.cpp 99068e21e0ebb0832d8d790bd2a1a1eca3addca3 
>   plugins/haze/icq-main-options-widget.h bef946cec890b649ee96e544293e30e85b2197a6 
>   plugins/haze/icq-main-options-widget.cpp b6dcbae0d419c732d9803b02410890774a683708 
>   plugins/haze/msn-main-options-widget.h 8dea406a74ae64286824986f03b50e789e49f0af 
>   plugins/haze/msn-main-options-widget.cpp 90d719e9c19f514040a01a311420e80eb17a926f 
>   plugins/haze/myspaceim-main-options-widget.h 6c6de7f29795ee688666c7e47b2d1154f1df167a 
>   plugins/haze/myspaceim-main-options-widget.cpp 94e475de6f89d5095bbcc9798b144600042e87cb 
>   plugins/haze/skype-main-options-widget.h e081243138497181336c5a9faa133973a3054490 
>   plugins/haze/skype-main-options-widget.cpp 87a3448601b2f338ca9d7361424b7a926c2b14ee 
>   plugins/haze/yahoo-main-options-widget.h 38ddb1a738bed52ba5b8b4f1c06de7924aef78d5 
>   plugins/haze/yahoo-main-options-widget.cpp d8bf7e132081ae1debad319a0cee6d3e1a218db0 
>   plugins/idle/main-options-widget.h bf50f3059ca4f9fb267079d71b777b666be32a40 
>   plugins/idle/main-options-widget.cpp f8aeb4b7bb777cc9b5973271344d1ebaac78aa52 
>   plugins/rakia/rakia-main-options-widget.h bd1291b8318dbc468b005a54315a9365aaf35b0c 
>   plugins/rakia/rakia-main-options-widget.cpp ecb4ee4ef4b23869b3f73077e49a5bd3ed7f035e 
>   plugins/salut/salut-main-options-widget.h ab51e1901340ab8630ba19e50b49c77eeb5ecd2d 
>   plugins/salut/salut-main-options-widget.cpp ff0339a29a5d2d79fd967a3eddbd9b5fd6fb97d3 
>   plugins/sunshine/sunshine-main-options-widget.h fbb6dca508d9bf7b313c4b14dcd1c2097cc772d5 
>   plugins/sunshine/sunshine-main-options-widget.cpp f6beaec2f60535abf00f3c86b562a547173477ab 
>   src/KCMTelepathyAccounts/abstract-account-parameters-widget.h 0c6cd95db610b7cebebe3e06ca15b446fd7d024d 
>   src/KCMTelepathyAccounts/abstract-account-parameters-widget.cpp b61e836b77809819a0f6f24f9b9b1bfe2a3af6a6 
>   src/KCMTelepathyAccounts/account-edit-widget.h 5db8119dfae2a31e51fca60daf40b6b083359f6f 
>   src/KCMTelepathyAccounts/account-edit-widget.cpp 312a4c913394c39e1b131994fbc0a8d02b84d5df 
>   src/add-account-assistant.cpp 52dd6f9493ac3db2930cbd419249afc823045230 
>   src/edit-account-dialog.cpp 37cb28faacbf63160eaa116924d015d5e59ed1ee 
>   src/salut-details-dialog.h 804d61b903bdf8c0946b1960aedac5b63b5b1b97 
>   src/salut-details-dialog.cpp f95826dcaa7b1fda96a695bd5f23ba9a3d4ffa63 
>   src/salut-enabler.h 7d4d640d19509024b9da269cb061ba43d2896dd9 
>   src/salut-enabler.cpp b16e57f27a736404b7f9afa11439f01e36eab484 
> 
> Diff: http://git.reviewboard.kde.org/r/103628/diff/
> 
> 
> Testing
> -------
> 
> Created an account and modified the display name.
> Edited an account and modified the display name.
> Created salut account and edited using the dialog.
> Edited salut account.
> Tested most of the plugins.
> More random tests.
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121121/a902b388/attachment-0001.html>

More information about the KDE-Telepathy mailing list