Review Request: Fix Chat Plasmoid Scrolling Bug (293522)

[David Edmundson]

> On Nov. 20, 2012, 10:52 a.m., David Edmundson wrote:
> > Am I right in thinking Aleix fixed this properly? 
> > I'm closing this if I don't hear back in a week.
> 
> Martin Klapetek wrote:
>     I don't remember/know all the details, but scrollbars in qml are not fixed yet - and it looks impossible to do without "abusing" the cacheBuffer property because of the different delegate heights. But I'm happy to be proven wrong.
> 
> Aleix Pol Gonzalez wrote:
>     What I did was to make sure that the view stays at the bottom when the conversation changes.
>     See https://git.reviewboard.kde.org/r/106791/diff/#index_header
>     
>     And AFAIK, it works fine...

so that patch doesn't fix this, and this should still be merged?


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105521/#review22251
-----------------------------------------------------------


On July 12, 2012, 7:54 a.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105521/
> -----------------------------------------------------------
> 
> (Updated July 12, 2012, 7:54 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This fixes the annoying bug stopping the plasmoid from scrolling properly as elegantly as possible.
> 
> The problems is that because delegates are created on demand, there's no way for the ListView to determine the height of all its content. It currently just takes the size of one delegate, and multiplies it by the amount of items in the model. While that works in scenarios where the delegates are all the same height, it does not here.
> 
> What this does is -abuse- use the cacheBuffer property to force it to keep all delegates in ram. While it uses more memory, it let's us work around this issue (Only other option is to remove the scrollbar). 
> 
> PS: I tried to set the cacheBuffer to view.count, but that made it ignore it completely (I think it can't change after initialized for it to be taken seriously).
> 
> 
> This addresses bug 293522.
>     http://bugs.kde.org/show_bug.cgi?id=293522
> 
> 
> Diffs
> -----
> 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/ChatWidget.qml 90cc07d 
>   plasmoid/org.kde.ktp-chatplasmoid/contents/ui/OutgoingDelegate.qml d713958 
>   tests/message-processor-basic-tests.h 35f931f 
>   tests/message-processor-basic-tests.cpp 554ce1a 
> 
> Diff: http://git.reviewboard.kde.org/r/105521/diff/
> 
> 
> Testing
> -------
> 
> Talked to myself.
> 
> 
> Thanks,
> 
> Lasath Fernando
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121120/2aa6b5ca/attachment.html>