Review Request: Improve contact list group header

Tue Nov 20 10:40:05 UTC 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106763/
-----------------------------------------------------------

(Updated Nov. 20, 2012, 10:40 a.m.)

Review request for Telepathy and KDE Usability.

Changes
-------

Usability team - what do you think about the orientation of the arrow (see the last row in the screenshots)?

Description
-------

I made several improvements to the group header in contact list:

 1) Moved the expand sign to the right
 2) Removed the tiny line
 3) Made the account/group icon slightly bigger (has the same size as the avatar in normal mode; might need adjusting)
 4) Aligned both the icon and the font with the contacts
 5) Used background color from palette disabled:highlight and lighter by factor of 10

This is more a visual review request than a code, I tried with several default KDE color schemes and I think it looks good in all of them, see the screenshot below. Let me know what you think (and if possible try using the patch for a while yourself and see how it fits).

Diffs
-----

  abstract-contact-delegate.cpp f5f2a05 

Diff: http://git.reviewboard.kde.org/r/106763/diff/

Testing
-------

Screenshots
-----------

New group header
  http://git.reviewboard.kde.org/r/106763/s/757/

Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121120/ad117c0b/attachment-0001.html>