Review Request: Port ContactRequestHandler to use new GlobalContactManager class

[David Edmundson]

> On Nov. 20, 2012, 8:53 a.m., Dominik Cermak wrote:
> > contact-request-handler.cpp, lines 54-55
> > <http://git.reviewboard.kde.org/r/107203/diff/1/?file=93669#file93669line54>
> >
> >     And what is this check for?
> >     Haven't seen a return in a constructor yet.

It is legal C++. 
It is also pointless. Removing :)


> On Nov. 20, 2012, 8:53 a.m., Dominik Cermak wrote:
> > contact-request-handler.cpp, line 52
> > <http://git.reviewboard.kde.org/r/107203/diff/1/?file=93669#file93669line52>
> >
> >     Maybe I'm just too dumb, but I don't see any other mention of 'accountMgr', so my question is: What is this assert for?

Well spotted. This would fail to compile with debug on.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107203/#review22236
-----------------------------------------------------------


On Nov. 20, 2012, 10:38 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107203/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2012, 10:38 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Port ContactRequestHandler to use new GlobalContactManager class
> 
> This removes a lot of code \o/ and is generally more readable.
> Also links the account to the newly added contact which will be useful for a future patche.
> 
> --
> 
> Code Tidy. Do not use "using namespace" in a header file.
> 
> Doing so means any file that happens to include this header now has a namespace implicitly set. This breaks the entire point of namespaces.
> 
> CCMAIL: rohangarg at kubuntu.org
> 
> 
> Diffs
> -----
> 
>   config/kcm_ktp_integration_module.desktop 8f49f0790cecff47efc318e11d1d51308673c2ff 
>   contact-request-handler.h 43456ee8f0a354ed075335d80a125da51713a0e9 
>   contact-request-handler.cpp ea24885970f46cecc58000d3330a3e2be2d39581 
>   contactnotify.h 462b3f3fe5f00efd330b0e07da52422b0b30ee74 
>   contactnotify.cpp 65bdaac8d273eb0a3d76eee406e34877e1649e59 
>   error-handler.h 5c033aa75f23993b18efe5dc708d07bac201a679 
>   error-handler.cpp 5bfe7ae0b79348eea2ddc5bfcd102823e7f6e6a5 
>   kded_ktp_integration_module.desktop d1fd9d35ca2ece7a7e4c688c68968f826d4ece18 
> 
> Diff: http://git.reviewboard.kde.org/r/107203/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121120/672e46cf/attachment.html>