Review Request: Use AccountsComboBox in AddContactDialog and JoinChatRoomDialog

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107321/#review22074
-----------------------------------------------------------

Ship it!


Ship It!

- Dan Vrátil


On Nov. 14, 2012, 5:50 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107321/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2012, 5:50 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Use AccountsComboBox in AddContactDialog and JoinChatRoomDialog
> 
> This removes incorrect usages of ContactModel to create lists of accounts in common internals,
> as well as removing some duplicate code.
> 
> This patch also fixes the JoinChatRoomDialog not updating as accounts become online/offline.
> 
> Note this breaks the API for all people using AddContactDialog (ktp-contact-list and ktp-presence-applet)
> (for the last time!)
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/add-contact-dialog.h cd4b66e9aabd045be6bf2185f6d262de4639e9eb 
>   KTp/Widgets/add-contact-dialog.cpp ddc26bdaa1e2f95f5cbd28633abaa95f5a0b8738 
>   KTp/Widgets/add-contact-dialog.ui 616fc71782e2721ca78e15df46778b93a7717432 
>   KTp/Widgets/join-chat-room-dialog.cpp 34905396d2d3c9795d1c1b81fdd4725e6d1b88ff 
>   KTp/Widgets/join-chat-room-dialog.ui 2d077c46a42b7f922d497bc3ba07efe421b542de 
> 
> Diff: http://git.reviewboard.kde.org/r/107321/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121116/85ccc5e7/attachment-0001.html>