Review Request: Update AddContactDialog to new parameters

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Wed Nov 14 07:23:02 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107322/#review21967
-----------------------------------------------------------

Ship it!


Ship It!

- Daniele Elmo Domenichelli


On Nov. 14, 2012, 6:31 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107322/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2012, 6:31 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Update AddContactDialog to new parameters
> 
> Also now allows us to remove the confusingly named "accountModel" method which returned a ContactsModel.
> Dvratil suggested I renamed it, I sort of ignored his comment as I knew I would be removing it soon.
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.h 3ed83b3e0d7383bb9d09d33be8b8a703809758cc 
>   contact-list-widget.cpp 159ae1d96b657d70f16a673a779e4a399ba6f7d0 
>   main-widget.cpp 174eb55aaf01770edb4e766602c1693db3287940 
> 
> Diff: http://git.reviewboard.kde.org/r/107322/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121114/3ec600aa/attachment-0001.html>


More information about the KDE-Telepathy mailing list