Review Request: Add Initial Kopete logs import dialog to Logviewer

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107263/#review21964
-----------------------------------------------------------

Ship it!


Make sure to blog about this


logviewer/log-viewer.cpp
<http://git.reviewboard.kde.org/r/107263/#comment16889>

    Restructure this so we don't have duplicate code.
    
    if (!matchingAccounts.isEmpty()) {
     doStuff();
    }
    
    logConfig.writeEntry(....)
    


- David Edmundson


On Nov. 9, 2012, 12:04 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107263/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 12:04 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> As discussed on IRC, moving the import dialog from KDED to logviewer to be run on logviewer startup.
> 
> 
> This addresses bug 246014.
>     http://bugs.kde.org/show_bug.cgi?id=246014
> 
> 
> Diffs
> -----
> 
>   logviewer/CMakeLists.txt 30d08ab 
>   logviewer/log-viewer.h b69753a 
>   logviewer/log-viewer.cpp ce39775 
>   logviewer/logs-import-dialog.h PRE-CREATION 
>   logviewer/logs-import-dialog.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/107263/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121114/b22b7cdd/attachment.html>