Review Request: Make the AccountsListModel more generic to use

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107319/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Turns out I wanted to break the API all over again :)

--
Use a custom AccountsListModel role to show enabled state and not Qt::CheckStateRole which is application specific.

This was causing checkboxes to appear in combo boxes showing a list of accounts
Also remove flags method which no longer has any effect on anything.

AccountsListModel now takes an AccountSet to know which accounts to show

--

We can't make it share the AccountsFilterModel, it doesn't really make sense to have one filter model that can cope with two different source roles and completely different usages. 

(as DrDanz suggested in an earlier review, this filter should be renamed to ContactsFilterModel, but I'm delaying that till we know what's happening with that.)

Right now only AccountsKCM uses this model. A patch for that is being uploaded alongside.


Diffs
-----

  KTp/Models/accounts-list-model.h f205a6973c1de54a188afb601866020b2f014898 
  KTp/Models/accounts-list-model.cpp d46011ac04efd2b00dadc0b45b8cce77aff386ff 
  KTp/Widgets/accounts-combo-box.h 92d6d993ed01028eedfedddb3eea8ff82539559c 
  KTp/Widgets/accounts-combo-box.cpp d427e9bf004053482aa3c592052b89f1e1f01f13 

Diff: http://git.reviewboard.kde.org/r/107319/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121114/984718f5/attachment.html>