Review Request: Make ktp-accounts-kcm compile again

Diego Casella polentino911 at gmail.com
Mon Nov 12 10:27:40 UTC 2012



> On Nov. 12, 2012, 9:16 a.m., David Edmundson wrote:
> > 1) There's way more than that needed. You must still have some old headers about.
> > 2) There's a review here: https://git.reviewboard.kde.org/r/107266/ which fixes everything.
> > 
> > It's not merged because I haven't had a "ship it!" on it
> > 
> > 
> > Thanks for getting involved though!

Yep, I noticed now that on other repos are affected indeed (i.e. ktp-contact-list,ktp-text-ui and ktp-presence-applet)  :)
Anyways, instead of leaving 5 repos in a broken state, wouldn't be more appropriate to put all these changes in separate branches and, once approved, push'em all into master?


- Diego


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107298/#review21863
-----------------------------------------------------------


On Nov. 12, 2012, 9:13 a.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107298/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2012, 9:13 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Seems like someone forgot to update an include statement due to some refactoring, and therefore the build process broke :)
> It's a very simple, one liner, patch which addresses that issue.
> 
> 
> Diffs
> -----
> 
>   src/accounts-list-delegate.cpp a233329 
> 
> Diff: http://git.reviewboard.kde.org/r/107298/diff/
> 
> 
> Testing
> -------
> 
> Tested against b9338a30fc3fcc41bab10fe79cb0fbaddaf57b98 and builds fine :)
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121112/d886457c/attachment.html>


More information about the KDE-Telepathy mailing list