Review Request: Port to AccountsListModel

Martin Klapetek martin.klapetek at gmail.com
Mon Nov 12 10:40:33 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107266/#review21868
-----------------------------------------------------------

Ship it!


...after fixing Dominik's comment. I think possible errors while removing accounts should be handled/displayed.

- Martin Klapetek


On Nov. 9, 2012, 3:46 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107266/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 3:46 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Port to AccountsListModel
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ee82fd0f82b3c158f1bef670b08120ef22974b6c 
>   src/account-item.h a2fee834c7e0e65931fa82c437be754e95ec333c 
>   src/account-item.cpp 8efc78fb135b7cf29b750fcfeb11c1b94eaa44a6 
>   src/accounts-list-delegate.cpp a2333290639588b6d6c09e3ae149083001da45d2 
>   src/accounts-list-model.h 10786674ab0d5a7bada9f6b3e3be9acd0aa235cd 
>   src/accounts-list-model.cpp 4a015fa517c625099f4fb05da3572e53b243d2ad 
>   src/edit-account-dialog.h d1c370d44dd0edd0f90726243a6e6f5dc38dbf48 
>   src/edit-account-dialog.cpp 5982e06bd8fe75d9972d38e91f4ae0c6d65a4a75 
>   src/kcm-telepathy-accounts.h 29629ebce869ac35882acce925551cd9dc49910a 
>   src/kcm-telepathy-accounts.cpp 6389a67410ab7a81c5378c216251747952853e5e 
> 
> Diff: http://git.reviewboard.kde.org/r/107266/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121112/e3e5ec40/attachment-0001.html>


More information about the KDE-Telepathy mailing list