Review Request: Make ktp-accounts-kcm compile again

David Edmundson david at davidedmundson.co.uk
Mon Nov 12 09:16:54 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107298/#review21863
-----------------------------------------------------------


1) There's way more than that needed. You must still have some old headers about.
2) There's a review here: https://git.reviewboard.kde.org/r/107266/ which fixes everything.

It's not merged because I haven't had a "ship it!" on it


Thanks for getting involved though!

- David Edmundson


On Nov. 12, 2012, 9:13 a.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107298/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2012, 9:13 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Seems like someone forgot to update an include statement due to some refactoring, and therefore the build process broke :)
> It's a very simple, one liner, patch which addresses that issue.
> 
> 
> Diffs
> -----
> 
>   src/accounts-list-delegate.cpp a233329 
> 
> Diff: http://git.reviewboard.kde.org/r/107298/diff/
> 
> 
> Testing
> -------
> 
> Tested against b9338a30fc3fcc41bab10fe79cb0fbaddaf57b98 and builds fine :)
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121112/846563ea/attachment.html>


More information about the KDE-Telepathy mailing list