Review Request: [logviewer] Fix potential crash and switching contacts in search results

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107273/#review21855
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Nov. 10, 2012, 9:45 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107273/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 9:45 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fix potential crash - I had a corrupted log file which caused Tpl::SearchHit::account() to be null and when using global search, it crashed logviewer
> 
> Fix switching contacts in search results - use global search so that you have at least two contacts left in the entity tree view, now try to switch between the contacts - dates in date picker are not updated and neither is the current conversation. This patch fixes it ;)
> 
> 
> Diffs
> -----
> 
>   logviewer/conversation-date-picker.cpp be43bb3 
> 
> Diff: http://git.reviewboard.kde.org/r/107273/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121112/d8625696/attachment.html>