Review Request: Fix build and a crash

Dan Vrátil dvratil at redhat.com
Sat Nov 10 09:13:34 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107272/
-----------------------------------------------------------

Review request for Telepathy.


Description
-------

Fix build - after Daniele's changes in TpLQt4 buildsystem, "make" does not produce libtelepathy-logger-qt4.so anymore, only .a

Fix crash - just got a crash when searching in logs, because item->date in some result was NULL


Diffs
-----

  TelepathyLoggerQt4/CMakeLists.txt 1c47376 
  TelepathyLoggerQt4/pending-search.cpp e4df41a 

Diff: http://git.reviewboard.kde.org/r/107272/diff/


Testing
-------

make install -> libtelepathy-logger-qt4.so installed
tried searching - no crash (in TpLQt4)


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121110/4a58227a/attachment.html>


More information about the KDE-Telepathy mailing list