Review Request: Do not hardcode group chat theme

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Fri Nov 9 23:22:53 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107132/
-----------------------------------------------------------

(Updated Nov. 9, 2012, 11:22 p.m.)


Review request for Telepathy.


Description
-------

This is a quick and dirty way to fix it, basically I duplicated the code for the single user chat and added a tabbed view.
Perhaps it could be a widget in order to avoid code duplication, but since we have just 2, I'd leave it like this for now, so that we can configure this in 0.6, and perhaps open a junior-job bug for this


This addresses bugs 282518 and 295843.
    http://bugs.kde.org/show_bug.cgi?id=282518
    http://bugs.kde.org/show_bug.cgi?id=295843


Diffs
-----

  config/appearance-config.ui 7fe6ce43a952652edcca229b918283b05268b240 
  lib/adium-theme-view.cpp 24b9c3570699f64e1b751183430e4975dc6a449d 
  config/appearance-config.h 5b6c83d6ac4001f1d28b3ce1cb8e18a38e5269c5 
  config/appearance-config.cpp 7f42857998b509a03dc8168181850a7a9a2a477d 

Diff: http://git.reviewboard.kde.org/r/107132/diff/


Testing
-------

Config works, group chat works


Thanks,

Daniele Elmo Domenichelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121109/e58ad919/attachment.html>


More information about the KDE-Telepathy mailing list