Review Request: Add navigation through history of sent messages in message editor

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106245/#review21724
-----------------------------------------------------------

Ship it!



lib/chat-text-edit.cpp
<http://git.reviewboard.kde.org/r/106245/#comment16820>

    bools don't need to be passed by reference



lib/chat-text-edit.cpp
<http://git.reviewboard.kde.org/r/106245/#comment16824>

    nitpick
    
    if ( 


- David Edmundson


On Aug. 27, 2012, 10:19 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106245/
> -----------------------------------------------------------
> 
> (Updated Aug. 27, 2012, 10:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> This implements navigation through history of sent messages by pressing Up and Down arrow keys like in Konversation. It's actually based on code from Konversation, I just didn't implement navigating by scrolling mouse wheel in the message editor as it's possible to have scrollbar in the message box (unlike in Konversation) and it would be extremely annoying for users if scrolling "beyond" end of the text would change the content of the message box.
> 
> I also tried populating the history of newly opened chat by a few last lines from last log, but I'm unsure about this feature. Subjectively it felt a bit confusing when I opened a new window and pressing Up key was pasting some text that appeared from "nowhere" and was not related to this session/conversation. But feel free to discuss, I can provide the code if you want to try. Alternatively we can just wait if users will ask for this functionality :)
> 
> 
> This addresses bug 303648.
>     http://bugs.kde.org/show_bug.cgi?id=303648
> 
> 
> Diffs
> -----
> 
>   lib/chat-text-edit.h 3e2dec0 
>   lib/chat-text-edit.cpp e4ca62c 
> 
> Diff: http://git.reviewboard.kde.org/r/106245/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121109/20364480/attachment.html>