Review Request: Fix Presence Applet settings

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107264/#review21713
-----------------------------------------------------------


That's not true, they're in the context menu

I would argue that: 
1) they're not settings relating to the plasmoid, so don't belong there
2) they don't physically fit without resizing

(did you know the battery applet only shows the configs there because the author didn't know how to add it to a context menu)

Justify the decision to me.

- David Edmundson


On Nov. 9, 2012, 1:13 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107264/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 1:13 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Atm the applet configuration dialog shows only the Plasma default pages, which is silly. Let's add the KCM Accounts and KDE Integration pages there!
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 7becc7e 
>   src/presenceapplet.h 5b462fc 
>   src/presenceapplet.cpp 33fc8cc 
> 
> Diff: http://git.reviewboard.kde.org/r/107264/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121109/3ec42d73/attachment.html>