Review Request: Import Kopete logs when adding new account in KCM

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107246/#review21684
-----------------------------------------------------------


Are we going to make Tp-Logger a hard dependency in 0.6?
Anyway I'd push this first https://git.reviewboard.kde.org/r/107119/ , so that you don't have to copy all the cmake stuff, and you can check the tp-logger-qt version (iirc deleting logs is not supported in 0.5)


src/kcm-telepathy-accounts.cpp
<http://git.reviewboard.kde.org/r/107246/#comment16808>

    What is the default value for warningContinueCancel? I don't want my logs deleted because I hit return twice instead of just one... and perhaps a dialogYesNo is more appropriate.
    
    Anyway 2 dialogs are redundant in my opinion, can we have just one with a "Delete logs" checkbox instead? Or 3 buttons "Delete Account", "Delete Account and Logs", "Cancel"


- Daniele Elmo Domenichelli


On Nov. 9, 2012, 9:52 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107246/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2012, 9:52 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> When you add a new account in the KCM, it will search for corresponding Kopete logs and ask whether to import them (and eventually import them).
> 
> 
> Bonus points for me: when you remove an account, you will be prompted whether you want to remove logs as well.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b4248fb 
>   cmake/modules/FindGIO.cmake PRE-CREATION 
>   cmake/modules/FindGObject.cmake PRE-CREATION 
>   cmake/modules/FindQtGLib.cmake PRE-CREATION 
>   cmake/modules/FindTelepathyGlib.cmake PRE-CREATION 
>   cmake/modules/FindTelepathyLogger.cmake PRE-CREATION 
>   cmake/modules/FindTelepathyLoggerQt4.cmake PRE-CREATION 
>   src/CMakeLists.txt ee82fd0 
>   src/kcm-telepathy-accounts.h 29629eb 
>   src/kcm-telepathy-accounts.cpp 6389a67 
> 
> Diff: http://git.reviewboard.kde.org/r/107246/diff/
> 
> 
> Testing
> -------
> 
> Added account I had on Kopete to KTp, got prompted whether to import logs, confirmed, logs imported.
> Removed account, got prompted whether to clear logs, confirmed, logs gone.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121109/2f754c39/attachment.html>