Review Request: Import Kopete logs when adding new account in KCM

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107246/#review21603
-----------------------------------------------------------



src/kcm-telepathy-accounts.cpp
<http://git.reviewboard.kde.org/r/107246/#comment16776>

    If the lifetime of an object is within a method create it on the stack.
    
    I.e
    
    KTp::LogsImporter logsImporter();
    
    Then you don't have to worry about deleting it and whatnot.
    
    



src/kcm-telepathy-accounts.cpp
<http://git.reviewboard.kde.org/r/107246/#comment16774>

    explain this



src/kcm-telepathy-accounts.cpp
<http://git.reviewboard.kde.org/r/107246/#comment16806>

    https://blogs.kde.org/2009/03/26/how-crash-almost-every-qtkde-application-and-how-fix-it-0


- David Edmundson


On Nov. 7, 2012, 2:34 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107246/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2012, 2:34 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> When you add a new account in the KCM, it will search for corresponding Kopete logs and ask whether to import them (and eventually import them).
> 
> 
> Bonus points for me: when you remove an account, you will be prompted whether you want to remove logs as well.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b4248fb 
>   cmake/modules/FindGIO.cmake PRE-CREATION 
>   cmake/modules/FindGObject.cmake PRE-CREATION 
>   cmake/modules/FindQtGLib.cmake PRE-CREATION 
>   cmake/modules/FindTelepathyGlib.cmake PRE-CREATION 
>   cmake/modules/FindTelepathyLogger.cmake PRE-CREATION 
>   cmake/modules/FindTelepathyLoggerQt4.cmake PRE-CREATION 
>   src/CMakeLists.txt ee82fd0 
>   src/kcm-telepathy-accounts.h 29629eb 
>   src/kcm-telepathy-accounts.cpp 6389a67 
> 
> Diff: http://git.reviewboard.kde.org/r/107246/diff/
> 
> 
> Testing
> -------
> 
> Added account I had on Kopete to KTp, got prompted whether to import logs, confirmed, logs imported.
> Removed account, got prompted whether to clear logs, confirmed, logs gone.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121109/7c811e64/attachment-0001.html>