Review Request: Models Update in Common Internals

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106432/#review21479
-----------------------------------------------------------

Ship it!


Looking good, comments below..


KTp/Models/accounts-list-model.h
<http://git.reviewboard.kde.org/r/106432/#comment16700>

    Not anymore :)



KTp/Models/accounts-list-model.h
<http://git.reviewboard.kde.org/r/106432/#comment16701>

    Minor, but might be fixed as well



KTp/Models/accounts-list-model.cpp
<http://git.reviewboard.kde.org/r/106432/#comment16702>

    I wonder if this should be called "Connected" as "Online" might be confused with "Available" presence, but the account can be any presence. Or maybe show the current account presence here? Should be just KTp::Presence(account->currentPresence).displayString()



KTp/Models/accounts-list-model.cpp
<http://git.reviewboard.kde.org/r/106432/#comment16703>

    Together with the above comment, the icon needs changing as well (and the icon should definitely reflect the presence)



KTp/Models/accounts-model-item.cpp
<http://git.reviewboard.kde.org/r/106432/#comment16704>

    This should be ::AccountRowType



KTp/Models/groups-model.h
<http://git.reviewboard.kde.org/r/106432/#comment16705>

    Star alignment


- Martin Klapetek


On Nov. 3, 2012, 7:26 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106432/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2012, 7:26 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Rename AccountsModel to ContactsModel as it is a model of contacts.
> 
> This is in preperation for providing a model of accounts to use in combo boxes everywhere. (this will be called AccountsModel, and would be very confusing if we don't rename this)
> 
> 
> Diffs
> -----
> 
>   KTp/Models/CMakeLists.txt 4bdff28aef93994ab88fde995952c48f126a34f2 
>   KTp/Models/accounts-filter-model.cpp 607df5492cacf96ca1f125760f51d5d900094e5e 
>   KTp/Models/accounts-list-model.h PRE-CREATION 
>   KTp/Models/accounts-list-model.cpp PRE-CREATION 
>   KTp/Models/accounts-model-item.cpp 12794178becf0fee635511b39d3a08726e75b64f 
>   KTp/Models/accounts-model.h caf93faa1aa95308d722a73accea0205abc8a6b8 
>   KTp/Models/accounts-model.cpp 8233a37f62808a7ba58bfcb4471bf734ad813a93 
>   KTp/Models/contact-model-item.cpp 110299846acbc1d36b7f9e17a4849222318676c4 
>   KTp/Models/contacts-model.h PRE-CREATION 
>   KTp/Models/contacts-model.cpp PRE-CREATION 
>   KTp/Models/groups-model-item.cpp d62829bba1fe2aa52d367327ea37018405f80d9a 
>   KTp/Models/groups-model.h 00e6f1a943b17dd07e54c30613e3566ba271aace 
>   KTp/Models/groups-model.cpp f0d607d2d13261f75158a26ebe274170062db2c4 
>   KTp/Models/proxy-tree-node.cpp fb5674bddffc5cc5d3c07662a5466d99f6b79fbb 
>   KTp/Widgets/CMakeLists.txt 708c8b0d67917ac862fed68966d7afb29e2770b7 
>   KTp/Widgets/accounts-combo-box.h PRE-CREATION 
>   KTp/Widgets/accounts-combo-box.cpp PRE-CREATION 
>   KTp/Widgets/add-contact-dialog.h a32633b6a86e2aefc728ed4b7b511de0c3e8d733 
>   KTp/Widgets/add-contact-dialog.cpp 7198c126df8354bbfa5df3bdf0020e1e8cf8b4cb 
>   KTp/Widgets/contact-grid-dialog.h 2df1c21b2983643922645a1c5efddd6dfe7ae198 
>   KTp/Widgets/contact-grid-dialog.cpp f454dee5e8b2fcca5cb663bbb762512ed3fd7c73 
>   KTp/Widgets/contact-grid-widget.h 256a09a7589d26bad2ec2e225777240993a2c67f 
>   KTp/Widgets/contact-grid-widget.cpp eb25d7e64df9979d9922a03750155af8432de570 
> 
> Diff: http://git.reviewboard.kde.org/r/106432/diff/
> 
> 
> Testing
> -------
> 
> Updated ContactList to the rename. Everything still works.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20121106/c7d013c2/attachment-0001.html>