Review Request: Retrieve and save refresh token for X-MESSENGER-OAUTH2 authentication

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104987/#review13967
-----------------------------------------------------------

Ship it!


Nice job as always! Few comments below. Also - I'm happy to ship this in 0.4 as it's another annoying bug, so huge +1.


x-messenger-oauth2-auth-operation.cpp
<http://git.reviewboard.kde.org/r/104987/#comment11080>

    I'd suggest to keep that, it doesn't hurt and can help users updating from 0.3.x directly (Kubuntu 12.04 LTS)



x-messenger-oauth2-auth-operation.cpp
<http://git.reviewboard.kde.org/r/104987/#comment11081>

    I know this is an old code but can this possibly output user's credentials?



x-messenger-oauth2-auth-operation.cpp
<http://git.reviewboard.kde.org/r/104987/#comment11082>

    Just for me to understand - both tokens are the same?



x-messenger-oauth2-prompt.cpp
<http://git.reviewboard.kde.org/r/104987/#comment11083>

    You can use QUrl::queryItemValue(QString key) here and access the needed value directly by queryItemValue(codeParameter).



x-messenger-oauth2-prompt.cpp
<http://git.reviewboard.kde.org/r/104987/#comment11084>

    Whitespace leftover ".parse ("


- Martin Klapetek


On May 18, 2012, 8:56 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104987/
> -----------------------------------------------------------
> 
> (Updated May 18, 2012, 8:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Retrieve and save refresh token for X-MESSENGER-OAUTH2 authentication.
> The refresh token will be used (in the future) to gain the access token when the old one is expired, so that the user can insert the password just the first time that he logs in.
> 
> The patch introduces the dependency on QJSON to parse the server reply, renames the token stored in KWallet from token to access_token, and stores the new refresh_token in kwallet. The authentication method is slightly different and requires another call to the server.
> 
> It's a bit late for 0.4, but I would like to ask for an exception, and to merge this part of the patch, so that perhaps I can add the second part (that will use the refresh token to get the new access token, and that I still need to write) in 0.4.1, as it won't introduce big changes. Sorry, but I was very busy recently...
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e6b1df7d1017483c8234c739f84c2cc81b339882 
>   cmake/modules/FindQJSON.cmake PRE-CREATION 
>   x-messenger-oauth2-auth-operation.cpp e4aa800faecb17d12c2524d6660eb9e871cb285f 
>   x-messenger-oauth2-prompt.h c87d6e7ea14c017cefd2db48d1e256802331a7eb 
>   x-messenger-oauth2-prompt.cpp c987ffdbde334c010a98478a28db740ae7bde049 
> 
> Diff: http://git.reviewboard.kde.org/r/104987/diff/
> 
> 
> Testing
> -------
> 
> access_token is retrieved and correctly used to log in, refresh_token is saved.
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120519/b14d2f37/attachment-0001.html>