Review Request: Fix crash when scrolling over overlay buttons and tidy up that code

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104887/
-----------------------------------------------------------

(Updated May 8, 2012, 8:27 p.m.)


Review request for Telepathy.


Changes
-------

The previous patch contained a bug that was always showing all the buttons regardless of the available capabilities. Fixed.


Description
-------

The overlay classes were massive mess, this severely tidies it up by merging several classes together as they only derived themselves for no real purpose and removes lots of unused or useless methods. Overall the code is much simpler and cleaner now. And it fixes the crash.


This addresses bug 293886.
    http://bugs.kde.org/show_bug.cgi?id=293886


Diffs (updated)
-----

  contact-delegate-overlay.h 2307044 
  contact-delegate-overlay.cpp 4733cdd 
  contact-delegate.cpp 8c6aebe 
  contact-list-widget.cpp 73be93c 
  contact-overlays.h f232c5c 
  contact-overlays.cpp 4200b46 
  contact-view-hover-button.h 4248987 
  contact-view-hover-button.cpp fd411b2 

Diff: http://git.reviewboard.kde.org/r/104887/diff/


Testing
-------

Everything still works.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120508/9f2c2eac/attachment.html>