Review Request: Use Tp-Qt Factories

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104779/#review13401
-----------------------------------------------------------

Ship it!



src/main.cpp
<http://git.reviewboard.kde.org/r/104779/#comment10537>

    You removed "Tp::DBusTubeChannel::FeatureBusNameMonitoring", and that's probably correct at the moment, but please add a comment here, so that we will remember in the future that we will need it for multi-user


Just fix this and the white space and then push! :D
If you don't have write access ping me on irc and I'll push it for you

- Daniele Elmo Domenichelli


On May 3, 2012, 4:58 p.m., Puneet Goyal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104779/
> -----------------------------------------------------------
> 
> (Updated May 3, 2012, 4:58 p.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> This patch makes use of Tp-Qt factories to set up the telepathy client registrar in main.cpp
> I have used the codebase at http://quickgit.kde.org/index.php?p=kwhiteboard.git&a=summary
> 
> 
> Diffs
> -----
> 
>   launcher/mainwindow.h 69d5c5f 
>   launcher/mainwindow.cpp 02c28ff 
>   src/kwhiteboard-handler.h f3c55d0 
>   src/kwhiteboard-handler.cpp d78b09e 
>   src/main.cpp 7e721f3 
> 
> Diff: http://git.reviewboard.kde.org/r/104779/diff/
> 
> 
> Testing
> -------
> 
> I have tested it and it runs successfully.
> 
> 
> Thanks,
> 
> Puneet Goyal
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120504/30511186/attachment.html>