Review Request: Add button in text-UI to load previous chat logs.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104057/#review13389
-----------------------------------------------------------

Ship it!



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104057/#comment10519>

    * align. Also check the cast.



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104057/#comment10518>

    One space too much



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/104057/#comment10520>

    There seems to be too many brackets -- KIcon((QLatinString("")))
    
    Also, KIcon allows empty constructor --> KIcon();



logviewer/entity-view.h
<http://git.reviewboard.kde.org/r/104057/#comment10525>

    Licence



logviewer/entity-view.h
<http://git.reviewboard.kde.org/r/104057/#comment10521>

    Whitespace



logviewer/entity-view.h
<http://git.reviewboard.kde.org/r/104057/#comment10524>

    Remove if unused



logviewer/entity-view.cpp
<http://git.reviewboard.kde.org/r/104057/#comment10526>

    Licence as well



logviewer/entity-view.cpp
<http://git.reviewboard.kde.org/r/104057/#comment10527>

    Whitespace at the end of the line


- Martin Klapetek


On May 3, 2012, 8:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104057/
> -----------------------------------------------------------
> 
> (Updated May 3, 2012, 8:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Option in the text-ui to load previous chat logs.
> 
> Adds optional toolbar item/menu entry in the text-ui
> Ktp-log-viewer reads command line args and auto-selects a user if account and contact ID are given.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 3a1e8d4 
>   app/chat-window.cpp 53c547c 
>   logviewer/CMakeLists.txt 44ec6e5 
>   logviewer/entity-view.h PRE-CREATION 
>   logviewer/entity-view.cpp PRE-CREATION 
>   logviewer/log-viewer.ui 039f0b1 
>   logviewer/main.cpp 7f7660b 
> 
> Diff: http://git.reviewboard.kde.org/r/104057/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120503/ad55eb9a/attachment.html>