Review Request: Porting MessageFilters

[Lasath Fernando]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104803/
-----------------------------------------------------------

(Updated May 3, 2012, 12:02 p.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

Addressed most of the issues David raised, too sleepy to go through drdanz's comments yet.


Description
-------

I'm starting do make some headway on my project (despite being swamped by Uni work at the moment), so I thought I may as well review what I've done so far.

Firstly, I gave MessageProcessor a KPluginLoader. I then cleaned it up, removed unneeded #includes, gave AbstractMessageFilter a camel case header etc.

Before I started porting the three existing filters to be KPlugins, I decided I should write unit tests for them. I'm not really sure on what the conventions are for tests because, well I haven't seen any on this project. So I made a few QTests and stuck them in a directory called tests.

I've ported EscapeFilter and EmoticonFilter. I just wrote tests for UrlFilter, but haven't got to port it yet. 

I also started documenting my work, in the hope that it'll make things easier to maintain. Currently, the Message class is more or less documented. 
If at all possible, I'd like someone who isn't familiar with how these work internally to read it and tell me if that documentation is clear.


Diffs (updated)
-----

  CMakeLists.txt e5dc102 
  filters/CMakeLists.txt PRE-CREATION 
  filters/emoticons/CMakeLists.txt PRE-CREATION 
  filters/emoticons/emoticon-filter.h PRE-CREATION 
  filters/emoticons/emoticon-filter.cpp PRE-CREATION 
  filters/emoticons/ktptextui_message_filter_emoticons.desktop PRE-CREATION 
  filters/escape/CMakeLists.txt PRE-CREATION 
  filters/escape/escape-filter.h PRE-CREATION 
  filters/escape/escape-filter.cpp PRE-CREATION 
  filters/escape/ktptextui_message_filter_escape.desktop PRE-CREATION 
  lib/CMakeLists.txt e94a432 
  lib/KTp/AbstractMessageFilter PRE-CREATION 
  lib/abstract-message-filter.h PRE-CREATION 
  lib/abstract-message-filter.cpp PRE-CREATION 
  lib/emoticon-filter.cpp 0e37aab 
  lib/escape-filter.cpp c366410 
  lib/filters.h 6059ea2 
  lib/ktptxtui_message_filter.desktop PRE-CREATION 
  lib/message-processor.h d6228b5 
  lib/message-processor.cpp a9b409e 
  lib/message.h c9d4340 
  lib/message.cpp ae947d2 
  tests/CMakeLists.txt PRE-CREATION 
  tests/message-processor-basic-tests.h PRE-CREATION 
  tests/message-processor-basic-tests.cpp PRE-CREATION 
  tests/sync-processor.h PRE-CREATION 
  tests/sync-processor.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104803/diff/


Testing
-------

THERE ARE UNIT TESTS!! :D


Thanks,

Lasath Fernando

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120503/b2b3a31a/attachment.html>