Review Request: Block/Unblock feature in ktp-text-ui module.

[Daniele Elmo Domenichelli]

> On March 30, 2012, 6:17 p.m., Daniele Elmo Domenichelli wrote:
> > Ship It!
> 
> Ahmed Ibrahim wrote:
>     I don't have the rights to commit the code. So could you please commit it.

Please push it in a personal clone (see http://community.kde.org/Sysadmin/GitKdeOrgManual) and ping on IRC, I will pull your commits from there an push them in the main repository.

Also remember to add to the last commit

FEATURE: <number of the bug/wish>  (if it is just a bug use BUG: instead)
REVIEW: <number of this review>
Reviewed-by: Name(s) of the person(s) who reviewed the patch


- Daniele Elmo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104407/#review12036
-----------------------------------------------------------


On March 30, 2012, 4:28 p.m., Ahmed Ibrahim wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104407/
> -----------------------------------------------------------
> 
> (Updated March 30, 2012, 4:28 p.m.)
> 
> 
> Review request for Telepathy and Daniele Elmo Domenichelli.
> 
> 
> Description
> -------
> 
> Added Block/Unblock contact button to the KActionCollection of the ktp-text-ui.
> Added also code that will help in displaying blocking/unblocking actions to the user in the ChatView.
> 
> 
> This addresses bug 292402.
>     http://bugs.kde.org/show_bug.cgi?id=292402
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h fd81141 
>   app/chat-window.cpp bd4fc35 
>   app/chatwindow.rc ac5a259 
>   app/main.cpp d76ce04 
>   lib/channel-contact-model.h 41d5d84 
>   lib/channel-contact-model.cpp d731322 
>   lib/chat-widget.h 10de317 
>   lib/chat-widget.cpp 0a0b5db 
> 
> Diff: http://git.reviewboard.kde.org/r/104407/diff/
> 
> 
> Testing
> -------
> 
> Blocked a contact and found that is blocked in another IM client and had other opened tabs and the button was changing according to the user's block state 
> 
> 
> Thanks,
> 
> Ahmed Ibrahim
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120331/8d75e4c1/attachment.html>