Review Request: Block/Unblock feature in ktp-text-ui module.

Ahmed Ibrahim ahmedibrahimkhali at gmail.com
Fri Mar 30 16:28:38 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104407/
-----------------------------------------------------------

(Updated March 30, 2012, 4:28 p.m.)


Review request for Telepathy and Daniele Elmo Domenichelli.


Changes
-------

Changed the user blocking/unblocking notification message as requested.
And since Martin has said that there is no need for KDualAction so I guess I don't have to implement that.


Description
-------

Added Block/Unblock contact button to the KActionCollection of the ktp-text-ui.
Added also code that will help in displaying blocking/unblocking actions to the user in the ChatView.


This addresses bug 292402.
    http://bugs.kde.org/show_bug.cgi?id=292402


Diffs (updated)
-----

  app/chat-window.h fd81141 
  app/chat-window.cpp bd4fc35 
  app/chatwindow.rc ac5a259 
  app/main.cpp d76ce04 
  lib/channel-contact-model.h 41d5d84 
  lib/channel-contact-model.cpp d731322 
  lib/chat-widget.h 10de317 
  lib/chat-widget.cpp 0a0b5db 

Diff: http://git.reviewboard.kde.org/r/104407/diff/


Testing
-------

Blocked a contact and found that is blocked in another IM client and had other opened tabs and the button was changing according to the user's block state 


Thanks,

Ahmed Ibrahim

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120330/9f3a5631/attachment.html>


More information about the KDE-Telepathy mailing list