Review Request: Make display name and icon configurable from accounts kcm

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104323/#review12032
-----------------------------------------------------------


This review has been submitted with commit fc25a790547251bcb4aa408d761c5f917bd27d14 by Daniele E. Domenichelli to branch master.

- Commit Hook


On March 30, 2012, 3:07 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104323/
> -----------------------------------------------------------
> 
> (Updated March 30, 2012, 3:07 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> There are a few rendering bugs in KWidgetItemDelegate, but the ugliest is fixed in kde 4.8.1, one is fixed in kdelibs KDE/4.8 branch and another one in in review
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 8fb139a673326be47b08c695c13c78d7534d1afb 
>   src/accounts-list-delegate.h 2c8b638ce244c261e9a8a462e3dca93ebd88948a 
>   src/accounts-list-delegate.cpp e818582ca3bd9b96079b1a0c9f10997b7649caf1 
>   src/change-icon-button.h PRE-CREATION 
>   src/change-icon-button.cpp PRE-CREATION 
>   src/edit-display-name-button.h PRE-CREATION 
>   src/edit-display-name-button.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104323/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/104323/s/478/
> 
>   http://git.reviewboard.kde.org/r/104323/s/479/
> 
> 
> Thanks,
> 
> Daniele Elmo Domenichelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120330/7ee6801d/attachment.html>