Review Request: Make display name and icon configurable from accounts kcm

Fri Mar 30 15:07:12 UTC 2012

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104323/
-----------------------------------------------------------

(Updated March 30, 2012, 3:07 p.m.)

Review request for Telepathy.

Changes
-------

Fixed David's issues

Description
-------

There are a few rendering bugs in KWidgetItemDelegate, but the ugliest is fixed in kde 4.8.1, one is fixed in kdelibs KDE/4.8 branch and another one in in review

Diffs (updated)
-----

  src/CMakeLists.txt 8fb139a673326be47b08c695c13c78d7534d1afb 
  src/accounts-list-delegate.h 2c8b638ce244c261e9a8a462e3dca93ebd88948a 
  src/accounts-list-delegate.cpp e818582ca3bd9b96079b1a0c9f10997b7649caf1 
  src/change-icon-button.h PRE-CREATION 
  src/change-icon-button.cpp PRE-CREATION 
  src/edit-display-name-button.h PRE-CREATION 
  src/edit-display-name-button.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/104323/diff/

Testing
-------

Works

Screenshots
-----------

  http://git.reviewboard.kde.org/r/104323/s/478/

  http://git.reviewboard.kde.org/r/104323/s/479/

Thanks,

Daniele Elmo Domenichelli

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120330/bef9c259/attachment-0001.html>