Review Request: Make the 'Now listening..' presence string configurable

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Thu Mar 29 08:19:17 UTC 2012



> On March 28, 2012, 10:23 p.m., Martin Klapetek wrote:
> > Fantastic, thanks!
> > 
> > If you don't have a git account, I can commit this for you.
> 
> Othmane Moustaouda wrote:
>     I don't have GIT account, can someone commit it? Thank you! :)

I think that if you have a kde identity account you should have a git account as well. Anyway, if you have more than one commit, and you cannot push on the main repository, push it somewhere (you can have a personal clone on kde git (see http://community.kde.org/Sysadmin/GitKdeOrgManual ) or somewhere else (github or gitorious will work). One of us can pull from there and push your commits to the main repo


- Daniele Elmo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104314/#review11966
-----------------------------------------------------------


On March 28, 2012, 10:18 p.m., Othmane Moustaouda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104314/
> -----------------------------------------------------------
> 
> (Updated March 28, 2012, 10:18 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Enabled the possibility for the user to set his custom 'Now listening' presence string
> 
> 
> This addresses bug 282944.
>     http://bugs.kde.org/show_bug.cgi?id=282944
> 
> 
> Diffs
> -----
> 
>   config/telepathy-kded-config.cpp 1fb515f56500407b7b221d1d5310237f8d94ca7f 
>   config/telepathy-kded-config.h 670c513df6b0cf7e69529f980a7f809b3f3d45a0 
>   config/nowplaying-listwidget.h PRE-CREATION 
>   config/nowplaying-listwidget.cpp PRE-CREATION 
>   config/CMakeLists.txt bd0b3f8dd89352d3b1f5e438f56123c508574ab4 
>   config/nowplaying-lineedit.h PRE-CREATION 
>   config/nowplaying-lineedit.cpp PRE-CREATION 
>   config/telepathy-kded-config.ui 0d616c5503b22f37c0ae4d5a94411d0f97b25d38 
>   telepathy-mpris.h d909863e68d0fdc7a6eb4ebb972d975ba224b6ef 
>   telepathy-mpris.cpp 8dae701a203f6c5ba43a622ce7125615b4392b63 
> 
> Diff: http://git.reviewboard.kde.org/r/104314/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Now playing changes
>   http://git.reviewboard.kde.org/r/104314/s/497/
> 
> 
> Thanks,
> 
> Othmane Moustaouda
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20120329/6a383202/attachment-0001.html>


More information about the KDE-Telepathy mailing list